This repository has been archived by the owner on Feb 13, 2018. It is now read-only.
Add support for specialist document attachments #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Specialist documents can have multiple attachments with titles. We capture the original filename so that we can present markdown hints for embedding the attachment in the admin UI.
it's cleaner to use `#select` than mapping to possibly nil values and then compacting. Also allow SafeHtml validator to be used on model classes which don't define GOVSPEAK_FIELDS, as it seems superfluous to define this on a model which doesn't have any fields.
| include GdsApi::TestHelpers::AssetManager | ||
|
|
||
| setup do | ||
| Attachable. |
Also tightened up the tests on specialist_document_edition to validate that the file upload does get triggered when saving the SpecialistDocumentEdition (verifying that the callbacks get fired on the embedded attachment document).
|
fixed those test failures, thanks Brad |
alext
added a commit
that referenced
this pull request
Mar 7, 2014
…ocument-edition Add support for specialist document attachments
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specialist documents can have multiple attachments with titles. We capture the original filename so that we can present markdown hints for embedding the attachment in the admin UI.